WIP: Test Coverage #14
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: jeff/goedlink#14
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "tests"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Reworked error handling and added initial tests
Error handling had to be revamped for proper testing. I also wrapped the
serial port in an interface so a mock port could be used for testing.
Initial test coverage is current a WIP.
forge.rights.ninja/jeff/goedlink/n8/n8command.go:31: SendString 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:52: GetConfig 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:66: CopyFolder 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:97: getFiles 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:114: getDirectories 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:134: CopyFile 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:208: SetConfig 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:217: Command 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:228: SelectGame 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:248: getTestMapper 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:274: MakeDir 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:291: Halt 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:310: HaltExit 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:323: MapLoadSDC 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:363: Reboot 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:383: LoadOS 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:442: LoadGame 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:514: GetVdc 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:530: GetRtc 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:546: SetRtc 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:566: EnterServiceMode 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:604: ExitServiceMode 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:636: isServiceMode 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:651: Recovery 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:717: bootWait 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:750: FifoWr 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:758: MemoryCrc 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:787: MemorySet 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:824: MemoryTest 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:854: ReadFlash 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:874: ReadMemory 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:927: WriteFlash 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:960: WriteMemory 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:994: fpgaPostInit 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:1016: FpgaInit 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:1037: FpgaInitFromFlash 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8command.go:1058: FpgaInitFromSD 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:46: GetSerialConfig 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:53: GetMapIndex 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:56: GetSubmap 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:59: GetPrgSize 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:62: GetChrSize 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:65: GetSrmSize 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:68: GetMasterVol 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:71: GetSSKeyMenu 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:74: GetSSKeySave 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:77: GetSSKeyLoad 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:80: GetMapCfg 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:83: GetCtrl 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:88: NewMapConfigFromBinary 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:101: NewMapConfig 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:113: NewConfigFromNesRom 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:143: Parse 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:157: Serialize 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:174: PrintFull 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:218: Print 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:227: boolToYesNo 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8config.go:234: getMask 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:43: GetFileInfo 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:79: SetFileInfo 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:90: DirRead 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:127: GetDirRecords 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:176: FileCrc 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:208: OpenFile 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:228: CloseFile 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:249: FileSetPointer 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:274: DirOpen 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:299: DirLoad 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:329: GetDirSize 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:345: ReadFile 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:389: ReadFileFromMemory 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:436: FileWrite 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:465: FileWriteFromMemory 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:509: mkdir 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:538: DeleteRecord 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:569: DiskInit 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:591: DiskRead 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8files.go:633: changeExtension 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8hardware.go:28: NewVdc 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8hardware.go:61: GetVals 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8hardware.go:70: Print 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8hardware.go:77: NewRtcTime 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8hardware.go:89: NewRtcTimeFromSerial 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8hardware.go:109: decToHex 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:91: Read 100.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:94: Write 100.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:97: Close 100.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:105: CloseSerial 100.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:115: InitSerial 71.4%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:142: TxData 100.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:158: Tx8 100.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:166: Tx16 100.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:174: Tx32 100.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:184: TxCmd 100.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:205: TxCmdExec 100.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:213: TxString 71.4%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:230: TxStringFifo 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:247: TxDataACK 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:280: RxData 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:304: Rx8 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:315: Rx16 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:326: Rx32 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:340: RxString 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:357: RxFileInfo 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:391: GetStatus 0.0%
forge.rights.ninja/jeff/goedlink/n8/n8serial.go:409: IsStatusOkay 0.0%
total: (statements) 4.1%
Total Coverage: 4.1%
Total Coverage: 6.1%
Total Coverage: 13.2%
Total Coverage: 15.1%
Total Coverage: 21.3%
Total Coverage: 28.1%
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.